Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

propose: adding exception handler #12

Closed
crhdev opened this issue Sep 2, 2024 · 1 comment
Closed

propose: adding exception handler #12

crhdev opened this issue Sep 2, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@crhdev
Copy link

crhdev commented Sep 2, 2024

Hi!
I was playing a little with the scheduler, it works great for small projects.
An improvement I should have implemented was exception handling when a command fails. Could something like this be integrated?

https://github.com/crhdev/cakephp-scheduler/blob/crhdev-patch-exception_handler/src/Command/ScheduleRunCommand.php#L52

@LordSimal
Copy link
Owner

yes, this would be a good idea.
I am just not sure if using the event system to react to exceptions is the correct way here... gotta have to think about that.

@LordSimal LordSimal added the enhancement New feature or request label Sep 8, 2024
LordSimal added a commit that referenced this issue Sep 12, 2024
LordSimal added a commit that referenced this issue Sep 12, 2024
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants