Skip to content
This repository has been archived by the owner on Oct 4, 2024. It is now read-only.

More console commands #186

Merged
merged 12 commits into from
Sep 4, 2024
Merged

More console commands #186

merged 12 commits into from
Sep 4, 2024

Conversation

rr-
Copy link
Collaborator

@rr- rr- commented Sep 4, 2024

  • Improve /tp
  • Add /kill
  • Add /give

Resolves #185.

@rr- rr- added this to the 0.3 milestone Sep 4, 2024
@rr- rr- self-assigned this Sep 4, 2024
@rr- rr- requested review from a team as code owners September 4, 2024 18:10
@rr- rr- requested review from lahm86, walkawayy and aredfan and removed request for a team September 4, 2024 18:10
Copy link
Collaborator

@lahm86 lahm86 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Only one note is /give all gives you keys/puzzles that aren't always loaded in the level. TR1X has a .loaded check on the object in Inv_AddItem - that's not decompiled yet as far as I can tell, so I'm assuming it doesn't do a similar check in OG, and so it's just adding everything it's given. I think it's fine to leave as-is until that is decompiled, otherwise it's a whole mess of conditions in the meantime for the Inv_AddItem calls.

@rr- rr- force-pushed the more-console-commands branch from 5c8d5d9 to 2959f6a Compare September 4, 2024 18:56
@rr-
Copy link
Collaborator Author

rr- commented Sep 4, 2024

LGTM.

Only one note is /give all gives you keys/puzzles that aren't always loaded in the level. TR1X has a .loaded check on the object in Inv_AddItem - that's not decompiled yet as far as I can tell, so I'm assuming it doesn't do a similar check in OG, and so it's just adding everything it's given. I think it's fine to leave as-is until that is decompiled, otherwise it's a whole mess of conditions in the meantime for the Inv_AddItem calls.

I'll decompile it and add the check.

  • Edit: done

@aredfan
Copy link

aredfan commented Sep 4, 2024

I found 2 issues.

  • If you execute the /kill command on an enemy riding a black skidoo, it crashes the game. (Level 11, room 98.)
  • The /kill command doesn't work on hostile monks. (Level 12.)

@rr- rr- force-pushed the more-console-commands branch from 2959f6a to 954dc0d Compare September 4, 2024 19:21
@rr-
Copy link
Collaborator Author

rr- commented Sep 4, 2024

  • Regression found: explosion sprites are too dark.

@rr-
Copy link
Collaborator Author

rr- commented Sep 4, 2024

  • And another: opening the inventory in Gym shows the passport, and you can't navigate back to see the stopwatch.

@rr- rr- force-pushed the more-console-commands branch 3 times, most recently from 7727fbc to a63bf69 Compare September 4, 2024 19:42
@aredfan
Copy link

aredfan commented Sep 4, 2024

  • /give flare gives you multiple flare boxes in Lara's Home and Home Sweet Home.

Edit: It happens in other levels as well.

@rr- rr- force-pushed the more-console-commands branch from a63bf69 to 2f7736a Compare September 4, 2024 20:18
@aredfan
Copy link

aredfan commented Sep 4, 2024

Looking really good so far! I did find a couple more issues.

  • It's possible to spawn only the bottom half of the dragon with these steps:

    1. /play 17
    2. /kill all
    3. /tp 2
    4. /fly to Bartoli and trigger the dragon
  • If you use /kill all when the dragon is active, whether half or whole, the game crashes.

Copy link

@aredfan aredfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great! Thank you. 👍

@rr- rr- merged commit b3dd230 into develop Sep 4, 2024
3 checks passed
@rr- rr- deleted the more-console-commands branch September 4, 2024 21:07
@rr- rr- added the TR2 label Oct 3, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TR2X bug: Lara's posture doesn't correct when /tp from water to dry rooms
3 participants