-
Notifications
You must be signed in to change notification settings - Fork 4
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Only one note is /give all
gives you keys/puzzles that aren't always loaded in the level. TR1X has a .loaded
check on the object in Inv_AddItem
- that's not decompiled yet as far as I can tell, so I'm assuming it doesn't do a similar check in OG, and so it's just adding everything it's given. I think it's fine to leave as-is until that is decompiled, otherwise it's a whole mess of conditions in the meantime for the Inv_AddItem
calls.
5c8d5d9
to
2959f6a
Compare
I'll decompile it and add the check.
|
I found 2 issues.
|
2959f6a
to
954dc0d
Compare
|
|
7727fbc
to
a63bf69
Compare
Edit: It happens in other levels as well. |
a63bf69
to
2f7736a
Compare
Looking really good so far! I did find a couple more issues.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great! Thank you. 👍
/tp
/kill
/give
Resolves #185.