Skip to content

More tag descriptions #1347

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Jul 19, 2022
Merged

More tag descriptions #1347

merged 2 commits into from
Jul 19, 2022

Conversation

carsakiller
Copy link
Collaborator

This PR adds en-us descriptions to locale/en-us/script.lua for:

@sumneko
Copy link
Collaborator

sumneko commented Jul 19, 2022

Thank you!

@sumneko sumneko merged commit 9ba0f94 into LuaLS:master Jul 19, 2022
@C3pa
Copy link
Contributor

C3pa commented Jul 19, 2022

carsakiller, would you mind adding these descriptions to the project's Wiki?

Not related, but where can I see the descriptions you added in this PR?

@carsakiller
Copy link
Collaborator Author

@C3pa I have been thinking of basically rewriting the wiki so it is formatted better and is easier to read. I haven't had the time just yet but I would like to spend the time to make it nicer to read and more detailed. I would also like permission from @sumneko before spending the large amount of time doing so.

The descriptions are offered in the completions context menu when typing out an annotation.
image

@sumneko
Copy link
Collaborator

sumneko commented Jul 19, 2022

Sure, you are free to improve the wiki.

@C3pa
Copy link
Contributor

C3pa commented Jul 19, 2022

@C3pa I have been thinking of basically rewriting the wiki so it is formatted better and is easier to read. I haven't had the time just yet but I would like to spend the time to make it nicer to read and more detailed. I would also like permission from @sumneko before spending the large amount of time doing so.

The descriptions are offered in the completions context menu when typing out an annotation. image

Thanks! I am looking forward to it.

@carsakiller carsakiller deleted the tag-descriptions branch July 28, 2022 17:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants