Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

fix: doc mistake in meta/3rd/OpenResty/library/prometheus.lua #2206

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

ellutionist
Copy link
Contributor

No description provided.

@ellutionist
Copy link
Contributor Author

Found this mistake by a the false positive diagnostic:
Screen Shot 2023-07-20 at 2 31 01 PM

@C3pa
Copy link
Contributor

C3pa commented Jul 20, 2023

Hi ellutionist, @carsakiller should know more, but I think you should also open the same PR against: https://github.com/LuaCATS/openresty/blob/80bc765b8e6e3e6351e7dbd90db32bd7763ec419/library/prometheus.lua#L237

@carsakiller
Copy link
Collaborator

Hello, yes, as C3pa said, please open this PR on the link they provided. These built-in libraries are slated for removal in the future and I would hate to lose any contributions. The plan is to keep the libraries up to date in LuaCATS, and I am working on improving the way we use definition files.

This can also be merged here in the meantime, however. 🙂

@carsakiller
Copy link
Collaborator

I don't have any experience with OpenResty. @flrgh, would you be able to weigh in here?

@flrgh
Copy link
Contributor

flrgh commented Jul 20, 2023

Looks like the correct fix to me, thanks @ellutionist :) as others have noted, please open this PR against https://github.com/LuaCATS/openresty, and we'll get it reviewed and merged.

@sumneko sumneko merged commit 8c4c122 into LuaLS:master Jul 21, 2023
@carsakiller
Copy link
Collaborator

Hey @ellutionist, are you able to open this PR on https://github.com/LuaCATS/openresty? If not, I can open it with you as a co-contributor 🙂

@ellutionist
Copy link
Contributor Author

Hey @ellutionist, are you able to open this PR on https://github.com/LuaCATS/openresty? If not, I can open it with you as a co-contributor 🙂

Sorry for the late reply. Thank you for creating the PR.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants