Skip to content

feat: support param snippets with space #2346

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Sep 26, 2023

Conversation

lewis6991
Copy link
Contributor

@lewis6991 lewis6991 commented Sep 25, 2023

Currently LuaLS will expand:

---<??>
local x = function (x, y) end

with:

---comment
---@param x any
---@param y any
local x = function (x, y) end

This change adds a variation of this snippet to expand:

--- <??>
local x = function (x, y) end

with:

--- comment
--- @param x any
--- @param y any
local x = function (x, y) end

Currently LuaLS will expand:

```lua
---<??>
local x = function (x, y) end
```

with:

```lua
---comment
---@param x any
---@param y any
local x = function (x, y) end
```

This change adds a variation of this snippet to expand:

```lua
--- <??>
local x = function (x, y) end
```

with:

```lua
--- comment
--- @param x any
--- @param y any
local x = function (x, y) end
```
@llllvvuu
Copy link

Thoughts on just making a breaking change here instead of adding a variation?

@sumneko sumneko merged commit f4548b5 into LuaLS:master Sep 26, 2023
@sumneko
Copy link
Collaborator

sumneko commented Sep 26, 2023

Thank you!

@lewis6991 lewis6991 deleted the feat/snipspace branch September 26, 2023 16:18
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants