Skip to content

Prefer https submodules #2397

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Oct 30, 2023
Merged

Conversation

gepbird
Copy link
Contributor

@gepbird gepbird commented Oct 30, 2023

Submodules that have git@github.com:person/repo url don't work when ssh or ssh keys are not set up properly, for example in minimal automated build environments like Nix. Use the https://github/person/repo url instead for more compatibility.

Closes #2396

@carsakiller
Copy link
Collaborator

Whoops, thanks!

@carsakiller carsakiller merged commit 4088f56 into LuaLS:master Oct 30, 2023
@gepbird gepbird deleted the prefer-https-submodules branch October 30, 2023 14:30
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot check out git submodules since LuaCATS transition
2 participants