add: load ENV variables as args #2655
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsakiller
commented
May 8, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started off with me taking a look at implementing #2330, but I am not sure how I would go about merging an ENV variable with a client configuration. Any tips on that would be great!
In the meantime, I have added loading of ENV variables for a bunch of the CLI args, as it was a pretty low-hanging fruit. So for example, instead of doing
./lua-language-server --doc="path/to/workspace", you can doexport LLS_DOC_PATH="path/to/workspace"and then just run./lua-language-server.