Skip to content

fix: default path for --doc_out_path is the current directory #3076

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

AndreasMatthias
Copy link
Contributor

Fixes #3073

Back then the default path of doc.json was LOGPATH. However the default path got lost after a refactoring in #2821. This commit reimplements the default path, but changes the default to the current directory.

Back then the default path of doc.json was LOGPATH.
However the default path got lost after a refactoring in LuaLS#2821.
This commit reimplements the default path, but changes
the default to the current directory.
@AndreasMatthias AndreasMatthias marked this pull request as ready for review February 14, 2025 12:32
changelog.md Outdated
@@ -2,7 +2,8 @@

## Unreleased
<!-- Add all new changes here. They will be moved under a version at release -->
* `FIX` incorrect argument skip pattern for `--check_out_path=`, which incorrectly skips the next argument
* `FIX` incorrect argument skip pattern for `--check_out_path=`, which incorrectly skips the next argumen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you seems modified the wrong line
(you incorrectly removed the t from the word argument)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This was a mistake.

@sumneko sumneko merged commit 1573c28 into LuaLS:master Feb 18, 2025
11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Option --doc_out_path no longer optional
3 participants