Skip to content

fix: fix type annotations for bit module #3091

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Mar 10, 2025
Merged

Conversation

dundargoc
Copy link
Contributor

Specifically for function bor, band and bxor, which all only
require one mandatory argument.

Reference: https://bitop.luajit.org/api.html

Specifically for function `bor`, `band` and `bxor`, which all only
require one mandatory argument.

Reference: https://bitop.luajit.org/api.html
@dundargoc dundargoc marked this pull request as ready for review February 23, 2025 16:50
@dundargoc
Copy link
Contributor Author

@sumneko does this look alright to you?

@tomlau10
Copy link
Contributor

Author might be busy at the moment.
The usual review/merge cycle is around 1-2 weeks in my experience

@sumneko sumneko merged commit 1d5aee3 into LuaLS:master Mar 10, 2025
11 checks passed
@dundargoc dundargoc deleted the fix/bit branch March 11, 2025 13:19
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants