Skip to content

Build for linux-arm64 #892

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Build for linux-arm64 #892

merged 1 commit into from
Jan 5, 2022

Conversation

aidos
Copy link
Contributor

@aidos aidos commented Jan 5, 2022

Fixes #891.

@sumneko
Copy link
Collaborator

sumneko commented Jan 5, 2022

Thank you!

@sumneko sumneko merged commit ee39688 into LuaLS:master Jan 5, 2022
@aidos
Copy link
Contributor Author

aidos commented Jan 5, 2022

Amazing! Thanks.

@kkremitzki
Copy link

Hello and thank you both for this. Although these arm64 builds are now available, some automated tooling (e.g. nvim-lsp-installer) does not pick them up since there hasn't been a release. Could you please consider possibly making a release sooner so that a manual install is not needed?

@sumneko
Copy link
Collaborator

sumneko commented Jan 12, 2022

In fact, this PR did not successfully build arm64, but it is still x64.
I plan to fully implement and release this version this week.

@aidos
Copy link
Contributor Author

aidos commented Jan 12, 2022

Apologies @sumneko, you're right — I thought I could just add to the build process. I've had a look at luamake etc, but with my limited understanding of the lua ecosystem, there's not enough info for me to make the changes required. Apologies for the half-baked PR.

@sumneko
Copy link
Collaborator

sumneko commented Jan 13, 2022

Unfortunately, I haven't found an easy way to compile linux-arm64, and there are still some problems that cannot be solved in the current cross-compilation.
Or we can wait for this: actions/runner-images#2552

@sumneko
Copy link
Collaborator

sumneko commented Apr 7, 2022

@kkremitzki
Copy link

The arm64 zip seems to work as expected, thanks.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Is it possible to add linux-arm64 to the build step?
3 participants