Allow extra options to be passed to psql calls with MIMIC-III #1195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable - thanks! Probably worth adding the to the MIMIC-IV version later. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
The
mimic-iii/buildmimic/postgres/scripts allow the database to be owned by any user, but the scriptmimic-iii/concepts/postgres_make_concepts.shdoes not currently support this. This patch gives thepostgres_make_concepts.shthe ability to do this, without changing its default behaviour.Note: the patch looks like it's rewritten every single line of this script, but actually the changes are very modest: the key change is to use a connection string rather than command-line options, which requires that
${CONNSTR}is double-quoted everywhere.