Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update row counts in validate scripts for mimic-iv-ed v2.2 #1476

Merged
merged 3 commits into from
Feb 4, 2023

Conversation

ZhipengHe
Copy link
Contributor

Hi there,
This pull request is to solve the issue #1475.

MIMIC-IV-ED v2.2 removed a subset of subject_id which will be retained internally as a test set. The document said Final row counts are available in the validation scripts published with the MIMIC Code Repository. However, the row counts are not updated for MIMIC-IV-ED v2.2 (Issue #1475)

I update row counts for validate.sql for both mysql and postgres, and save original validation scripts as validate_old.sql

Validate with new scripts:

    tbl    | expected_count | observed_count | row_count_check
-----------+----------------+----------------+-----------------
 diagnosis |         899050 |         899050 | PASSED
 edstays   |         425087 |         425087 | PASSED
 medrecon  |        2987342 |        2987342 | PASSED
 pyxis     |        1586053 |        1586053 | PASSED
 triage    |         425087 |         425087 | PASSED
 vitalsign |        1564610 |        1564610 | PASSED
(6 rows)

@alistairewj
Copy link
Member

I removed the "old" scripts since the git history can keep track of validation scripts for the old versions. I also tidied up one comment. Thanks!

@alistairewj alistairewj merged commit 570ef01 into MIT-LCP:main Feb 4, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants