Update postgres-make-concepts.sql #1494
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks to me like the file `medication/norepinephrine.sql` is missing here. Therefore, the scripts for the dependent tables are failing (and also `score/sofa.sql` which also seems to be dependent). 😄
alistairewj
added a commit
that referenced
this pull request
Mar 23, 2023
was due to a regex match succeeding against similarly named norepinephrine_equivalent_dose. fix was to change to exact matching with grep. re-ran to regenerate psql concepts. fixed #1494
|
Thanks for highlighting this. The postgres-make-concepts script is actually automatically generated by convert_bigquery_to_postgres.sh. The bug is that it skipped adding |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks to me like the file
medication/norepinephrine.sqlis missing here. Therefore, the scripts for the dependent tables are failing (and alsoscore/sofa.sqlwhich also seems to be dependent). 😄