Fix/pyviz #31
Merged
Fix/pyviz #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nathanhhughes Maybe, this is intentional, but there seems to be references to nodes in the removed layers (e.g., deleting a room node fails after removing the building node as it thinks the parent still exists). I updated to remove nodes before removing the layer. Does this make sense? |
|
Yeah, not intentional (I recently added the ability to remove a layer but hadn't needed to use it yet). I'll probably tweak the implementation slightly after it's merged, but it makes sense and is the correct behavior. Idk what happened with CI, but good to (squash and) merge whenever you're ready |
nathanhhughes
force-pushed
the
feature/auto_abstractions
branch
from
eaab6f2 to
83b1d9d
Compare
nathanhhughes
force-pushed
the
fix/pyviz
branch
from
0fe0eb0 to
1c0c03c
Compare
nathanhhughes
merged commit c0b51a9
into
feature/auto_abstractions
1 of 4 checks passed
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A minor change to make the python visualizer work with recent sparpk_dsg update + added remove_layer binding.