Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

soccerdata ahead of socceraction #797

Closed
lehoff opened this issue Aug 19, 2024 · 1 comment
Closed

soccerdata ahead of socceraction #797

lehoff opened this issue Aug 19, 2024 · 1 comment

Comments

@lehoff
Copy link

lehoff commented Aug 19, 2024

I was getting started with soccerdata as the first step on my football analytics journey and when I wanted to investigate SPADL output from soccerdata I had to add socceraction, but there is a dependency problem:

Because no versions of socceraction match >1.5.3,<2.0.0
 and socceraction (1.5.3) depends on lxml (>=4.9.3,<5.0.0), socceraction (>=1.5.3,<2.0.0) requires lxml (>=4.9.3,<5.0.0).
And because soccerdata (1.8.2) depends on lxml (>=5.0.0,<6.0.0), socceraction (>=1.5.3,<2.0.0) is incompatible with soccerdata (1.8.2).
So, because footballdata depends on both soccerdata (1.8.2) and socceraction (^1.5.3), version solving failed.

As there is an overlap in contributors between soccerdata and soccerdata I would like to hear if there is anything fundamental that stop bumping lxml on socceraction. If not, I could try to patch things up and submit a PR, but if there is anything deeper than a version mismatch I would draw a blank :-)

probberechts added a commit to probberechts/soccerdata that referenced this issue Aug 23, 2024
Adds socceraction to the lock file to ensure the dependencies are compatible.

See ML-KULeuven/socceraction#797
probberechts added a commit to probberechts/soccerdata that referenced this issue Aug 23, 2024
Adds socceraction to the lock file to ensure the dependencies are compatible.

See ML-KULeuven/socceraction#797
probberechts added a commit to probberechts/soccerdata that referenced this issue Aug 23, 2024
Adds socceraction to the lock file to ensure the dependencies are compatible.

See ML-KULeuven/socceraction#797
probberechts added a commit to probberechts/soccerdata that referenced this issue Aug 23, 2024
Adds socceraction to the lock file to ensure the dependencies are compatible.

See ML-KULeuven/socceraction#797
@probberechts
Copy link
Member

Thanks for reporting this. It should have been fixed in probberechts/soccerdata#692.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants