Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

refactor(netcdf): updates focused on flopy parity #2163

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

mjreno
Copy link
Contributor

@mjreno mjreno commented Jan 24, 2025

Adjustment to model NetCDF input file creation that align with FloPy #2417:

  • Fix DIS mesh_face_x array, which was off by an index
  • Rotate mesh x and y coordinates when angle of rotation has been specified
  • Structured export projected coordinates are never rotated. Only translate if angrot is 0.0, otherwise leave in grid local coordinates.
  • Structured exports support either latitude / longitude geographic coordinates or a projection variable for grid mapping via the wkt string but not both. Latitude and longitude coordinates can be rotated.
  • change global attributes "modflow6_grid" and "modflow6_model" to "modflow_grid" and "modflow_model", as these identifiers might be more generally applied
  • After FloPy PR is merged, a follow up PR will update autotests to use new functionality

Checklist of items for pull request

  • Replaced section above with description of pull request
  • Formatted new and modified Fortran source files with fprettify
  • Updated definition files
  • Removed checklist items not relevant to this pull request

For additional information see instructions for contributing and instructions for developing.

@mjreno mjreno marked this pull request as draft January 24, 2025 19:00
@mjreno mjreno marked this pull request as ready for review February 20, 2025 21:07
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant