-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
ci(release): reinit release notes, update dist scripts #1283
Conversation
To me, the development version should be from packaging.version import Version
# This is the latest release to compare to
v642 = Version("6.4.2")
v = Version("6.dev4")
print(f"{v.major=} {v.minor=} {v.micro=} {v.dev=} {v > v642}")
# v.major=6 v.minor=0 v.micro=0 v.dev=4 False
v = Version("6.4.3.dev0")
print(f"{v.major=} {v.minor=} {v.micro=} {v.dev=} {v > v642}")
# v.major=6 v.minor=4 v.micro=3 v.dev=0 True and if you want to get fancy, things like setuptools-scm use git describe for the dev local info based on the git hash. For example 1ce12a2 would be version from subprocess import check_output
check_output('git describe --dirty --tags --long --match "*[0-9]*"', text=True).strip()
# 6.4.2-3-g1ce12a2de0
v = Version("6.4.3.dev3+g1ce12a2de0")
print(f"{v.major=} {v.minor=} {v.micro=} {v.dev=} {v.local=} {v > v642}")
# v.major=6 v.minor=4 v.micro=3 v.dev=3 v.local='g1ce12a2de0' True |
Thank you @mwtoews the hope was less frequent need to change develop branch version numbers but I see it was wrong / out of order. Updated to your suggestion |
Would you suggest any way to achieve something like |
From what I've seen, usually the "next release" is just to increment the micro number, so long as it has something like "dev" in it. The actual version number, when published, can jump up to a major version. Often these decisions are made close to the release, depending on things like big new features or breaking changes. |
* reinit release notes for next development cycle * add --repo-owner option to build_docs.py * use .mf6minsim model for sample mf6 output in docs * refactor update_version.py to use packaging.version * convert version.txt to plain text * convert dev version to v6.4.3.dev0 * sub version into release notes folder structure
eba830a
to
b16d58d
Compare
f18bfee
to
e4e87ce
Compare
@mwtoews after discussion it was decided to bump minor instead of micro, otherwise I believe the plan is to adopt your proposed scheme here, flopy and other related repos. Thanks for the guidance here |
…1283) * reinit release notes for next development cycle * add --repo-owner option to build_docs.py * use .mf6minsim model for sample mf6 output in docs * refactor update_version.py to use packaging.version * convert version.txt to plain text * convert development version to v6.4.3.dev0 * include ostag in versions subbed into docs * check dist subdirs in check_dist.py * include meson.options in full dist
update_version.py
withpackaging.version.Version
and convertversion.txt
to plain text.mf6minsim
for sample mf6 output inbuild_docs.py
instead of ex-gwf-twri01 fromex-gwf-twri.py
--repo-owner
option tobuild_docs.py
to allow testing on a forkmeson.options
to full distributioncheck_dist.py
example script tests: previously expected run scripts to be in top-level example model dir, but some examples have nested subdirs