Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enhance ocean conservation task #1003

Merged
merged 4 commits into from
Jul 2, 2024

Conversation

cbegeman
Copy link
Collaborator

@cbegeman cbegeman commented May 6, 2024

Here, we add conservation plot types for all the ocean's mass flux terms.

@cbegeman cbegeman force-pushed the enhance-ocn-conservation-task branch from b55150d to a4e88d5 Compare June 25, 2024 14:22
@cbegeman cbegeman requested a review from xylar June 25, 2024 14:23
@cbegeman cbegeman marked this pull request as ready for review June 25, 2024 14:23
@cbegeman
Copy link
Collaborator Author

Co-authored-by: Xylar Asay-Davis <xylarstorm@gmail.com>
@cbegeman
Copy link
Collaborator Author

cbegeman commented Jul 1, 2024

@xylar Would you like to try running again with the time string fix? I think your case might be more likely to trigger an issue.

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

I reran the test suite after rebasing this branch onto #1010 (which includes some fixes unrelated to this branch). Results are here:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/enhance-ocn-conservation-task/

Everything looks good, notably the sea-ice time series are now plotting without error.

@xylar xylar self-assigned this Jul 2, 2024
@xylar xylar merged commit cb99f91 into MPAS-Dev:develop Jul 2, 2024
5 checks passed
@cbegeman
Copy link
Collaborator Author

cbegeman commented Jul 2, 2024

Thank you, @xylar!

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants