Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Update test suite to kill jobs with invalid deps #872

Merged
merged 1 commit into from
Apr 20, 2022
Merged

Update test suite to kill jobs with invalid deps #872

merged 1 commit into from
Apr 20, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Apr 20, 2022

On Anvil, the test suite has been leaving behind main vs. control jobs when the main job fails. With a flag (--kill-on-ivalid-dep=yes), this shouldn't happen anymore.

@xylar
Update test suite to kill jobs with invalid deps
31ebb2e 
On Anvil, the test suite has been leaving behind main vs. control
jobs when the main job fails.  With a flag
(`--kill-on-ivalid-dep=yes`), this shouldn't happen anymore.
@xylar
Copy link
Collaborator Author

xylar commented Apr 20, 2022

Testing

I ran the test suite on Anvil:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/anvil/fix_suite_dependencies/
All tests completed successfully so this is only a partial test of this functionality but I think we will see soon enough whether it works so I don't want to artificially force it right now. The main thing is that the syntax is correct and it doesn't break the suite.

@xylar xylar merged commit 430a8f5 into MPAS-Dev:develop Apr 20, 2022
@xylar xylar deleted the fix_suite_dependencies branch April 20, 2022 08:52
@darincomeau darincomeau mentioned this pull request Aug 15, 2022
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar