Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Arctic Ocean time series, profiles, and TS diagrams to polar regions #896

Merged
merged 13 commits into from
Sep 29, 2022

Conversation

@cbegeman
Copy link
Collaborator Author

@milenaveneziani The depth interval for profiles and time series for Arctic Ocean regions could be modified to more appropriate values. I just didn't know what the best default would be.

@cbegeman
Copy link
Collaborator Author

The TS diagrams for this coarse mesh don't turn out very well. I don't know if there's something we'd want to tweak here (not volumetric? different bins?).
image

@cbegeman
Copy link
Collaborator Author

@xylar
Copy link
Collaborator

xylar commented Sep 22, 2022

@cbegeman, this looks amazing! I'll run this on a SORRM and an ARRM run just to make sure things work out fine on a variety of meshes. But everything looked good to me when I looked through the code.

@cbegeman cbegeman changed the title Add Arctic Ocean time series and TS diagrams to polar regions Add Arctic Ocean time series, profiles, and TS diagrams to polar regions Sep 22, 2022
@milenaveneziani
Copy link
Collaborator

milenaveneziani commented Sep 24, 2022

@cbegeman: thanks for fixing this!
I think the T/S binning for the diagrams looks good now.
For the depth intervals, I think the current defaults could be changed to: 0-bottom, 0-100, 100-500m. This way we have a rough sense of the top-to-bottom trends, and the trends for the surface layer and the Atlantic Water layer. After changing these defaults, I think this is ready to merge.

@xylar
Copy link
Collaborator

xylar commented Sep 24, 2022

@milenaveneziani

I think the current defaults could be changed to: 0-bottom, 0-100, 100-500m.

I don't think we currently support multiple depth intervals, and that would be a big enough change to warrant a separate PR. Do you have a preference for which of these we support for now?

Copy link
Collaborator

@xylar xylar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks to me like we might need to decrease the hard-coded lower bound on density contours in the code:

contours = numpy.arange(24., 29.+rhoInterval, rhoInterval)

https://portal.nersc.gov/project/e3sm/xylar/analysis/arrm/20220803.WCYCL1950.ne30pg2_ARRM10to60E2r1.baseline.cori-knl/ts_0011-0020_climo_0011-0020/ocean/TS_diagram_ArcticOceanRegions_ArcticOcean-noBarents,KaraSeas_ANN.png
Maybe 23?

I also wondered if you are open to adding Hovmoller plots for Arctic Ocean Regions as part of this PR? It seems like it would fit into very will with the other 3 and they were conspicuously missing when I looked through the analysis.

[hovmollerOceanRegions]
## options related to plotting Hovmoller diagrams (depth vs. time plots) of
## regional means of 3D MPAS fields
# the names of region groups to plot, each with its own section below
regionGroups = ['Antarctic Regions']
[hovmollerAntarcticRegions]
## options related to plotting Hovmoller diagrams of Antarctic Regions
# a list of dictionaries for each field to plot. The dictionary includes
# prefix (used for file names, task names and sections) as well as the MPAS
# name of the field, units for colorbars and a the name as it should appear
# in figure titles and captions.
fields =
[{'prefix': 'potentialTemperature',
'mpas': 'timeMonthly_avg_activeTracers_temperature',
'units': r'$$\degree$$C',
'titleName': 'Potential Temperature'},
{'prefix': 'salinity',
'mpas': 'timeMonthly_avg_activeTracers_salinity',
'units': r'PSU',
'titleName': 'Salinity'},
{'prefix': 'potentialDensity',
'mpas': 'timeMonthly_avg_potentialDensity',
'units': r'kg m$$^{-3}$$',
'titleName': 'Potential Density'}]
# a list of region names from the region masks file to plot
regionNames = ["Southern Ocean 60S", "Weddell Sea Shelf",
"Weddell Sea Deep", "Bellingshausen Sea Shelf",
"Bellingshausen Sea Deep", "Amundsen Sea Shelf",
"Amundsen Sea Deep", "Eastern Ross Sea Shelf",
"Eastern Ross Sea Deep", "Western Ross Sea Shelf",
"Western Ross Sea Deep", "East Antarctic Seas Shelf",
"East Antarctic Seas Deep"]
# whether to compute an anomaly with respect to the start of the time series
computeAnomaly = False
# Number of points over which to compute moving average(e.g., for monthly
# output, movingAveragePoints=12 corresponds to a 12-month moving average
# window)
movingAveragePoints = 12

mpas_analysis/polar_regions.cfg Outdated Show resolved Hide resolved
mpas_analysis/polar_regions.cfg Outdated Show resolved Hide resolved
mpas_analysis/polar_regions.cfg Outdated Show resolved Hide resolved
Comment on lines 82 to 87
Tbins = numpy.linspace(-2.5, 8.0, 211)
Sbins = numpy.linspace(33.5, 35.5, 401)
Sbins = numpy.linspace(30, 35.5, 201)

# density contour interval
rhoInterval = 0.1
rhoInterval = 0.2

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure why we added the [TSDiagramsForArcticOceanRegions] section here but I think it makes sense to remove it and instead to make these edits in default.cfg.

It looks to me from the plots like rhoInterval = 0.4 might be more appropriate, given this broad salinity range.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I think you could even go back to 0.2 with the revised density range you now have.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But I'm fine with 0.3.

@milenaveneziani
Copy link
Collaborator

@xylar:

I don't think we currently support multiple depth intervals, and that would be a big enough change to warrant a separate PR. Do you have a preference for which of these we support for now?

oops, I had forgotten about that. Then we could just do the 0 to bottom depth range for now. And yes, I could always add a min,zmax to each geometric_feature, but probably not a big priority at the moment. (thanks for letting me know about that feature though: I had not realized we could that).

And yes, could point about reducing the minimum density for the TS diagrams rho contours to 23.

Copy link
Collaborator

@milenaveneziani milenaveneziani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great @cbegeman. Thanks!

@xylar
Copy link
Collaborator

xylar commented Sep 27, 2022

Thank @cbegeman. I'll rerun the analysis that I ran before (but likely not tonight) and re-review once I have it.

@milenaveneziani
Copy link
Collaborator

I know I have already approved this, but I am thinking to run a test as well. Will let you know how it goes.

@milenaveneziani
Copy link
Collaborator

@xylar
Copy link
Collaborator

xylar commented Sep 27, 2022

@cbegeman, this is so great! Here's my SORRM analysis:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/arctic_regions/v2.cryo.Bcase.submesoscale.ne30pg2_SOwISC12to60E2r4.chrysalis/clim_0001-0020_ts_0001-0020/ocean/index.html

I wouldn't change anything here, it's ready to go. The one thing I noticed that we might want to change down the road is that Thermal Forcing might not make a lot of sense to plot in the Arctic, since we don't typically worry about melting ice shelves there. But it does no harm.

@xylar xylar self-assigned this Sep 27, 2022
@xylar
Copy link
Collaborator

xylar commented Sep 27, 2022

I will merge this as soon as I make the v1.7.2 release. I'm not adding new major features to that release but it'll be in 1.8.0!

@cbegeman cbegeman force-pushed the add_arctic_ocean_to_polar_regions branch from 7b84206 to 1448292 Compare September 27, 2022 20:38
@cbegeman
Copy link
Collaborator Author

@xylar I think I interpreted your comment incorrectly and you don't want me to remove the thermal forcing. I removed the commit 7b84206

@xylar
Copy link
Collaborator

xylar commented Sep 27, 2022

@cbegeman, I have no problem with you having removed it. I think that's what we want in the long run. I just didn't want to make more work for you.

@xylar
Copy link
Collaborator

xylar commented Sep 27, 2022

@cbegeman, maybe go ahead and add your commit back that removed TF for Arctic since you have it already.

@cbegeman
Copy link
Collaborator Author

@xylar All set!

@xylar
Copy link
Collaborator

xylar commented Sep 29, 2022

Great, thanks @cbegeman! Such good work and I already feel like we've learned quite a bit from these plots just in the runs we did to test the new analysis.

@xylar xylar merged commit 36e4add into MPAS-Dev:develop Sep 29, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants