Skip to content

Add missing var when continuing MOC calculation #901

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 25, 2022
Merged

Add missing var when continuing MOC calculation #901

merged 1 commit into from
Sep 25, 2022

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Sep 24, 2022

I think I forgot to run the test suite on #886 and thus missed this issue.

@xylar xylar added the bug label Sep 24, 2022
@xylar xylar self-assigned this Sep 24, 2022
@xylar xylar mentioned this pull request Sep 24, 2022
Merged
@xylar
Copy link
Collaborator Author

xylar commented Sep 25, 2022

Testing

The test suite on Anvil was mostly successful. The only failure was in xarray_master and that has been fixed in #902.
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xylar/analysis_testing/chrysalis/fix_moc_in_main_vs_ctrl/

Notably, the main vs. control test case that was failing for #900 is now succeeding.

@xylar xylar merged commit 3ade01b into MPAS-Dev:develop Sep 25, 2022
@xylar xylar deleted the fix_moc_in_main_vs_ctrl branch September 25, 2022 02:04
@xylar xylar mentioned this pull request Sep 25, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees

@xylar xylar

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@xylar