Add a check for duplicate analysis tasks and subtasks #908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xylar
commented
Sep 27, 2022
Comment on lines
-79
to
+80
| subtasks : ``OrderedDict`` of ``AnalysisTasks`` | ||
| Subtasks of this task, with subtask names as keys | ||
| subtasks : list of mpas_analysis.shared.AnalysisTask | ||
| Subtasks of this task |
There was a problem hiding this comment.
An incorrect docstring I noticed in the process of writing the function above.
TestingI made sure tasks listed fine for this branch. I tested this on a branch with duplicate task names and got the expected error when I did: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happens frequently by mistake and produces a very obscure error message. With this merge, the error message will be more straightforward, e.g.: