Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Support shapely 2.0 #940

Merged
merged 9 commits into from
Jan 16, 2023
Merged

Support shapely 2.0 #940

merged 9 commits into from
Jan 16, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented Dec 29, 2022

We need a new version of geometric_features and mpas_tools to support the newest shapely.

Since the inset maps also use shapely, some tests have been added to make sure they work with the new shapely.

In the process, a bug was found where points did not plot correctly. This has been fixed here.

A deprecation warning related to registering color maps and some minor clean-up are also included for convenience.

@xylar xylar self-assigned this Dec 29, 2022
@xylar xylar marked this pull request as ready for review January 12, 2023 07:12
@xylar xylar force-pushed the support_shapely_2.0 branch 2 times, most recently from 94ee740 to 31920c9 Compare January 16, 2023 17:12
@xylar xylar force-pushed the support_shapely_2.0 branch from 0e414cf to a5a5a7d Compare January 16, 2023 18:02
@xylar
Copy link
Collaborator Author

xylar commented Jan 16, 2023

Testing

The test suite on Chrysalis is almost done. Results are here:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis_testing/chrysalis/support_shapely_2.0/

Only the main_vs_ctrl is still running. I'll update when it's done.

Update: main_vs_ctrl also finished succesfully.

@xylar xylar merged commit ea79a5e into MPAS-Dev:develop Jan 16, 2023
@xylar xylar deleted the support_shapely_2.0 branch January 16, 2023 18:49
@xylar
Copy link
Collaborator Author

xylar commented Jan 17, 2023

Oops, #941 got included here by mistake. I guess no harm done.

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant