Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add Adusumilli et al. (2020) melt rates #961

Merged
merged 10 commits into from
May 18, 2023

Conversation

xylar
Copy link
Collaborator

@xylar xylar commented May 8, 2023

This merge switches climatology maps of Antarctic melt rates to use Adusumilli et al. (2020) instead of Rignot et al. (2013). It also adds the Adusumilli et al. melt rates and fluxes to the time-series plots as a 3rd observational point (keeping Rignot et al. 2013 present-day and steady-state estimates).

To do:

  • run test suite
  • run for SORRM simulation
  • update documentation

@xylar xylar requested review from milenaveneziani and cbegeman May 8, 2023 20:00
@xylar xylar self-assigned this May 8, 2023
@xylar
Copy link
Collaborator Author

xylar commented May 8, 2023

@cbegeman and @milenaveneziani, although I've marked you to review, there's not a big rush on this. It likely makes sense to wait until LCRC is back up next week and maybe until after the Hackathon to look this over.

@xylar
Copy link
Collaborator Author

xylar commented May 9, 2023

Testing

I ran the test suite on Perlmutter. Results can be found here:
https://portal.nersc.gov/cfs/e3sm/xylar/analysis_testing/pm-cpu/add-adusumilli-melt-rates/

In particular, the Adusumilli et al. (2020) melt rates can be seen in both climatology maps:
image
and time series:
image

Copy link
Collaborator

@cbegeman cbegeman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar This all looks great! What testing would you like from me?

@xylar
Copy link
Collaborator Author

xylar commented May 16, 2023

@cbegeman, good question. If you have time, you could run MPAS-Analysis using this branch on a decade of a recent SORRM simulation.

I plan to use this branch on the 3 runs for the paper (I just haven't got to it since LCRC came back up). Once that's done, I'll ask you to have a look at that, too.

ds_out.to_netcdf(f'{out_prefix}_{out_grid_name}.{date}.nc')


def compute_regional_means(in_filename, out_prefix, date, chunk_size=50000,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cbegeman, here's the function I would appreciate you sanity-checking if you have time.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xylar I looked it over and I think it's correct. Thanks!

@xylar
Copy link
Collaborator Author

xylar commented May 17, 2023

Here is the analysis from a 5-year run on SORRM that used prescribed melt rates from Adusumilli, which makes for a nice sanity check both on the analysis and on the prescribed melt fluxes:
https://web.lcrc.anl.gov/public/e3sm/diagnostic_output/ac.xasay-davis/analysis/20230516.GMPAS-IAF-DISMF.T62_SOwISC12to60E2r4.chrysalis/

Melt fields are nearly identical, with small differences due to interpolation artifacts:
image

Regionally averaged melt time series are similar but slightly smaller from MPAS-Ocean, e.g.:
image

@xylar
Copy link
Collaborator Author

xylar commented May 17, 2023

@cbegeman, if the analysis I've done so far is sufficient for you to be happy, I don't think you need to do anything else in your review except give it a look. (A second pair of eyes on the regional preprocessing was the main thing I wanted.)

@xylar
Copy link
Collaborator Author

xylar commented May 17, 2023

@milenaveneziani, do you have time to give this a look?

@milenaveneziani
Copy link
Collaborator

Looks great to me @xylar.

Sort of unrelated question: what does the 'SS' stand for in one of the Rignot's labels?

Copy link
Collaborator

@milenaveneziani milenaveneziani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved based on visual inspection and developer testing.

@xylar
Copy link
Collaborator Author

xylar commented May 18, 2023

Sort of unrelated question: what does the 'SS' stand for in one of the Rignot's labels?

Steady state. This would be the melt rates if the ice sheet were in equilibrium instead of losing mass. (So an approximation of what melt rates might have been in preindustrial times.)

@xylar
Copy link
Collaborator Author

xylar commented May 18, 2023

Thanks @milenaveneziani!

@xylar xylar merged commit 7521b68 into MPAS-Dev:develop May 18, 2023
@xylar xylar deleted the add-adusumilli-melt-rates branch May 21, 2023 20:24
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants