Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Don't include FCINCLUDES in build options checked for build compatibility #1197

Merged

Conversation

mgduda
Copy link
Contributor

@mgduda mgduda commented Jun 27, 2024

This PR removes FCINCLUDES from the set of build variables that are checked for build compatibility.

With commit c740150, the FCINCLUDES variable is modified with core-specific options (for the atmosphere core specifically) and so including FCINCLUDES in the set of build options that are checked for compatibility in the top-level Makefile leads to a failed check, forcing a clean between the compilation of the atmosphere core and other cores.

The FCINCLUDES variable contains very similar information to the CPPINCLUDES variable, which is included in compatibility checks, and in order to enable the atmosphere core to be compiled after compilation of another core, this PR removes FCINCLUDES from the variables that are checked for build compatibility.

…lity

With commit c740150, the FCINCLUDES variable is modified with core-specific
options (for the atmosphere core specifically) and so including FCINCLUDES in
the set of build options that are checked for compatibility in the top-level
Makefile leads to a failed check, forcing a clean between the compilation of the
atmosphere core and other cores.

The FCINCLUDES variable contains very similar information to the CPPINCLUDES
variable, which is included in compatibility checks, and in order to enable the
atmosphere core to be compiled after compilation of another core, this commit
removes FCINCLUDES from the variables that are checked for build compatibility.
Copy link
Collaborator

@gdicker1 gdicker1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as advertised, approved!

@mgduda mgduda merged commit 82681e9 into MPAS-Dev:release-v8.2.0 Jun 27, 2024
@mgduda mgduda deleted the framework/no_FCINCLUDES_check branch June 27, 2024 22:04
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants