Don't include FCINCLUDES in build options checked for build compatibility #1197
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
FCINCLUDES
from the set of build variables that are checked for build compatibility.With commit c740150, the
FCINCLUDES
variable is modified with core-specific options (for the atmosphere core specifically) and so includingFCINCLUDES
in the set of build options that are checked for compatibility in the top-levelMakefile
leads to a failed check, forcing a clean between the compilation of the atmosphere core and other cores.The
FCINCLUDES
variable contains very similar information to theCPPINCLUDES
variable, which is included in compatibility checks, and in order to enable the atmosphere core to be compiled after compilation of another core, this PR removesFCINCLUDES
from the variables that are checked for build compatibility.