CodeQL

[lihui] #N/A refactor: fix code smell #396

# to view logs

GitHub Actions / Qodana Community for JVM completed Apr 5, 2024 in 0s

25 new problems found by Qodana Community for JVM

Qodana Community for JVM

25 new problems were found

Inspection name	Severity	Problems
`Nullability and data flow problems`	🔶 Warning	11
`Unchecked warning`	🔶 Warning	11
`Lombok @Getter may be used`	🔶 Warning	1
`Suspicious variable/parameter name combination`	🔶 Warning	1
`Unused import`	🔶 Warning	1

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

Register at Qodana Cloud and configure the action
Use GitHub Code Scanning with Qodana
Host Qodana report at GitHub Pages
Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.3.2
        with:
          upload-result: true

Contact Qodana team

Contact us at qodana-support@jetbrains.com

Or via our issue tracker: https://jb.gg/qodana-issue
Or share your feedback: https://jb.gg/qodana-discussions

Details

This result was published with Qodana GitHub Action

Annotations

Check warning on line 134 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Nullability and data flow problems

Condition `ownerComboBox.getItem() instanceof OwnerDTO` is redundant and can be replaced with a null check

Check warning on line 67 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Nullability and data flow problems

Method invocation `getTrelloBoardMembers` may produce `NullPointerException`

Check warning on line 86 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Nullability and data flow problems

Method invocation `getTrelloBoardLabels` may produce `NullPointerException`

Check warning on line 57 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/UserSelectedInfo.java

github-actions / Qodana Community for JVM

Nullability and data flow problems

Method invocation `getLine` may produce `NullPointerException`

Check warning on line 89 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/controller/TwCodeReviewSettingsConfigurable.java

github-actions / Qodana Community for JVM

Nullability and data flow problems

Method invocation `getTrelloApiKey` may produce `NullPointerException`

Check warning on line 57 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/UserSelectedInfo.java

github-actions / Qodana Community for JVM

Nullability and data flow problems

Argument `selectionStartPosition` might be null

Check warning on line 62 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/UserSelectedInfo.java

github-actions / Qodana Community for JVM

Nullability and data flow problems

Argument `selectionEndPosition` might be null

Check warning on line 130 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Nullability and data flow problems

Condition `labelComboBox.getItem() instanceof LabelDTO` is redundant and can be replaced with a null check

Check warning on line 62 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/UserSelectedInfo.java

github-actions / Qodana Community for JVM

Nullability and data flow problems

Method invocation `getLine` may produce `NullPointerException`

Check warning on line 78 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Nullability and data flow problems

Method invocation `getTrelloBoardMembers` may produce `NullPointerException`

Check warning on line 62 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Nullability and data flow problems

Method invocation `getTrelloBoardLabels` may produce `NullPointerException`

Check warning on line 26 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/intellij/UserSelectedInfo.java

github-actions / Qodana Community for JVM

Lombok @Getter may be used

Field 'project' may have Lombok @Getter

Check warning on line 49 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Suspicious variable/parameter name combination

'height' should probably not be passed as parameter 'width'

Check warning on line 79 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Unchecked warning

Unchecked call to 'CollectionComboBoxModel(List)' as a member of raw type 'com.intellij.ui.CollectionComboBoxModel'

Check warning on line 88 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Unchecked warning

Unchecked call to 'ComboBox(ComboBoxModel)' as a member of raw type 'com.intellij.openapi.ui.ComboBox'

Check warning on line 88 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Unchecked warning

Unchecked assignment: 'com.intellij.openapi.ui.ComboBox' to 'com.intellij.openapi.ui.ComboBox'

Check warning on line 68 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Unchecked warning

Unchecked call to 'CollectionComboBoxModel(List)' as a member of raw type 'com.intellij.ui.CollectionComboBoxModel'

Check warning on line 63 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Unchecked warning

Unchecked assignment: 'com.intellij.ui.CollectionComboBoxModel' to 'javax.swing.ComboBoxModel'

Check warning on line 87 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Unchecked warning

Unchecked call to 'CollectionComboBoxModel(List)' as a member of raw type 'com.intellij.ui.CollectionComboBoxModel'

Check warning on line 80 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Unchecked warning

Unchecked call to 'ComboBox(ComboBoxModel)' as a member of raw type 'com.intellij.openapi.ui.ComboBox'

Check warning on line 68 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Unchecked warning

Unchecked assignment: 'com.intellij.ui.CollectionComboBoxModel' to 'javax.swing.ComboBoxModel'

Check warning on line 80 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Unchecked warning

Unchecked assignment: 'com.intellij.openapi.ui.ComboBox' to 'com.intellij.openapi.ui.ComboBox'

Check warning on line 94 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Unchecked warning

Unchecked call to 'setRenderer(ListCellRenderer)' as a member of raw type 'com.intellij.openapi.ui.ComboBoxWithWidePopup'

Check warning on line 63 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/ui/CodeReviewPanel.java

github-actions / Qodana Community for JVM

Unchecked warning

Unchecked call to 'CollectionComboBoxModel(List)' as a member of raw type 'com.intellij.ui.CollectionComboBoxModel'

Check warning on line 20 in src/main/java/net/lihui/app/plugin/thoughtworkscodereviewtools/client/TrelloClient.java

github-actions / Qodana Community for JVM

Unused import

Unused import `import java.util.stream.Collectors;`

View more details on GitHub Actions