FFmpeg-7.0 fixes #1031
Merged
FFmpeg-7.0 fixes #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm testing this patch in the Debian package now. I recommend squashing the two commits into one unified commit with improvided description. |
|
This looks great, would love to see this merged to fix issues with Arch! |
|
Thanks - I'm not actively maintaining SSR anymore, it's nice to see others still care enough about it to provide fixes :). |
Closed
petterreinholdtsen
added a commit
to petterreinholdtsen/ssr
that referenced
this pull request
Aug 12, 2024
Use class method GetChannels() as a wrapper to get the ffmpeg version dependent implementation instead of the channels method which disappeared with ffmpeg 7. This is needed in addiontion to the changes in MaartenBaert#1031.
MingcongBai
pushed a commit
to AOSC-Tracking/ssr
that referenced
this pull request
Aug 27, 2024
Use class method GetChannels() as a wrapper to get the ffmpeg version dependent implementation instead of the channels method which disappeared with ffmpeg 7. This is needed in addiontion to the changes in MaartenBaert#1031.
MingcongBai
pushed a commit
to AOSC-Tracking/ssr
that referenced
this pull request
Aug 27, 2024
Use class method GetChannels() as a wrapper to get the ffmpeg version dependent implementation instead of the channels method which disappeared with ffmpeg 7. This is needed in addiontion to the changes in MaartenBaert#1031.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FF_API_OLD_CHANNEL_LAYOUT api was removed in ffmpeg-7.0 so src/AV/Output/AudioEncoder.cpp and src/AV/Output/Synchronizer.cpp fail to compile. Fix this while remaining compatible with older ffmpeg versions.