-
Notifications
You must be signed in to change notification settings - Fork 293
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Port to Qt6 #1052
Closed
Closed
Port to Qt6 #1052
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tested in KDE Plasma 6.2, works pretty good, so ready for review |
It works with Qt6-6.8.1. Not KDE. Thank you! |
@MaartenBaert ping |
Fixed an issue of signal signature: diff.txt
|
MaartenBaert
added a commit
that referenced
this pull request
Jan 12, 2025
Nice work, however you can't just remove Qt4/5 support, it's still needed for older linux distributions. I've incorporated your changes in a backward-compatible way. Let me know if you experience any issue. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm still not shure how to properly do some things, e.g. check if X11 compositor is running (currently it simply checks if XComposite extension is available).
Also we need to deal with scaling workarounds(Qt6 has no problem with fractional scaling)Closes #1045