Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Port to Qt6 #1052

Closed
wants to merge 6 commits into from
Closed

Port to Qt6 #1052

wants to merge 6 commits into from

Conversation

Sunderland93
Copy link

@Sunderland93 Sunderland93 commented Jan 5, 2025

I'm still not shure how to properly do some things, e.g. check if X11 compositor is running (currently it simply checks if XComposite extension is available). Also we need to deal with scaling workarounds(Qt6 has no problem with fractional scaling)

Closes #1045

@Sunderland93 Sunderland93 marked this pull request as draft January 5, 2025 13:38
@Sunderland93 Sunderland93 changed the title Port to Qt6 [WIP] Port to Qt6 Jan 5, 2025
@Sunderland93 Sunderland93 marked this pull request as ready for review January 6, 2025 07:23
@Sunderland93 Sunderland93 changed the title [WIP] Port to Qt6 Port to Qt6 Jan 6, 2025
@Sunderland93
Copy link
Author

Tested in KDE Plasma 6.2, works pretty good, so ready for review

@walmstudio
Copy link

Работает

simplescreenrecorder-2025-01-06_12.41.21.mp4

image

Извините, если не в том месте выложил

@4fury-c3440d8
Copy link

It works with Qt6-6.8.1. Not KDE. Thank you!

@Sunderland93
Copy link
Author

@MaartenBaert ping

@dsheeler
Copy link

dsheeler commented Jan 9, 2025

Fixed an issue of signal signature: diff.txt

diff --git a/src/GUI/PageInput.cpp b/src/GUI/PageInput.cpp
index ef5b011..2facd88 100644
--- a/src/GUI/PageInput.cpp
+++ b/src/GUI/PageInput.cpp
@@ -367,7 +367,7 @@ PageInput::PageInput(MainWindow* main_window)
 			m_checkbox_record_cursor = new QCheckBox(tr("Record cursor"), groupbox_video);
 
 			connect(m_combobox_video_backend, SIGNAL(activated(int)), this, SLOT(OnUpdateVideoAreaFields()));
-			connect(m_buttongroup_video_x11_area, SIGNAL(buttonClicked(int)), this, SLOT(OnUpdateVideoAreaFields()));
+			connect(m_buttongroup_video_x11_area, SIGNAL(buttonClicked(QAbstractButton*)), this, SLOT(OnUpdateVideoAreaFields()));
 			connect(m_combobox_x11_screens, SIGNAL(activated(int)), this, SLOT(OnUpdateVideoAreaFields()));
 			connect(m_combobox_x11_screens, SIGNAL(popupShown()), this, SLOT(OnIdentifyScreens()));
 			connect(m_combobox_x11_screens, SIGNAL(popupHidden()), this, 

SLOT(OnStopIdentifyScreens()));

MaartenBaert added a commit that referenced this pull request Jan 12, 2025
@MaartenBaert
Copy link
Owner

Nice work, however you can't just remove Qt4/5 support, it's still needed for older linux distributions. I've incorporated your changes in a backward-compatible way. Let me know if you experience any issue.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration to Qt6.
5 participants