Skip to content

[Bug] Evening compliments are shown during the day #3727

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Closed
2 of 4 tasks
rejas opened this issue Feb 26, 2025 · 0 comments
Closed
2 of 4 tasks

[Bug] Evening compliments are shown during the day #3727

rejas opened this issue Feb 26, 2025 · 0 comments
Assignees
@rejas
Labels
bug ready (coming with next release)

Comments

@rejas
Copy link
Collaborator

rejas commented Feb 26, 2025

Environment

SYSTEM: manufacturer: Apple Inc.; model: MacBookPro18,3; virtual: false

OS: platform: darwin; distro: macOS; release: 15.3.1; arch: arm64; kernel: 24.3.0

VERSIONS: electron: 32.3.0; used node: 22.11.0; installed node: 22.11.0; npm: 10.9.0; pm2: 5.4.3

OTHER: timeZone: Europe/Berlin; ELECTRON_ENABLE_GPU: undefined

Which start option are you using?

npm run start

Are you using PM2?

No

Module

compliments

Have you tried disabling other modules?

  • Yes
  • No

Have you searched if someone else has already reported the issue on the forum or in the issues?

  • Yes

What did you do?

Happens when the compliments array of the morning/day times is not set at all instead of being an empty array.

What did you expect to happen?

no compliments being shown

What actually happened?

evening events are shown since the code falls into them as a fallback

Additional comments

No response

Participation

  • I am willing to submit a pull request for this change.
@rejas rejas added the bug label Feb 26, 2025
@rejas rejas mentioned this issue Feb 26, 2025
Merged
@rejas rejas self-assigned this Feb 26, 2025
khassel pushed a commit that referenced this issue Feb 27, 2025
@rejas
Fix empty part-of-day logic (#3726)
4a398f0 
Fixes #3727

---------

Co-authored-by: veeck <gitkraken@veeck.de>
@rejas rejas mentioned this issue Apr 1, 2025
Merged
rejas added a commit that referenced this issue Apr 1, 2025
@rejas @MichMich
@KristjanESPERANTO @dependabot @khassel @crazyscot @bugsounet @jkriegshauser @illimarkangur @sdetweil @vppencilsharpener @Paranoid93 @btoconnor @WallysWellies @JasonStieber @jargordon @dkallen78 @ryan-d-williams @skpanagiotis @MarcLandis @HeikoGr @pedrolamas @MagMar94 @Developer-Incoming @n8many @mixasgr @savvadam @geraki @OWL4C
Release 2.31.0 (#3758)
39a614e 
Thanks to: @Developer-Incoming, @eltociear, @geraki, @khassel,
@KristjanESPERANTO, @MagMar94, @mixasgr, @n8many, @OWL4C, @rejas,
@savvadam, @sdetweil.

> ⚠️ This release needs nodejs version `v22.14.0 or higher`

### Added

- Add CSS support to the digital clock hour/minute/second through the
use of the classes `clock-hour-digital`, `clock-minute-digital`, and
`clock-second-digital`.
- Add Arabic (#3719) and Esperanto translation.
- Mark option `secondsColor` as deprecated in clock module.
- Add Greek translation to Alerts module.
- [newsfeed] Add specific ignoreOlderThan value (override) per feed
(#3360)
- [weather] Added option Humidity to hourly View
- [weather] Added option to hide hourly entries that are Zero, hiding
the entire column if empty.
- [updatenotification] Added option to iterate over modules directory
instead using modules defined in `config.js` (#3739)

### Changed

- [core] starting clientonly now checks for needed env var
`WAYLAND_DISPLAY` or `DISPLAY` and starts electron with needed
parameters (if both are set wayland is used) (#3677)
- [core] Optimize systeminformation calls and output (#3689)
- [core] Add issue templates for feature requests and bug reports
(#3695)
- [core] Adapt `start:x11:dev` script
- [weather/yr] The Yr weather provider now enforces a minimum
`updateInterval` of 600 000 ms (10 minutes) to comply with the terms of
service. If a lower value is set, it will be automatically increased to
this minimum.
- [weather/weatherflow] Fixed icons and added hourly support as well as
UV, precipitation, and location name support.
- [workflow] Run `sudo apt-get update` before installing packages to
avoid install errors
- [workflow] Exclude issues with label `ready (coming with next
release)` from stale job

### Removed

### Updated

- [core] Update requirements and dependencies including electron to v35
and formatting (#3593, #3693, #3717)
- [core] Update prettier, ESLint and simplify config
- Update Greek translation

### Fixed

- [calendar] Fix clipping events being broadcast (#3678)
- [tests] Fix Electron tests by running them under new github image
ubuntu-24.04, replace xserver with labwc, running under xserver and
labwc depending on env variable WAYLAND_DISPLAY is set (#3676)
- [calendar] Fix arrayed symbols, #3267, again, add testcase, add
testcase for #3678
- [weather] Fix wrong weatherCondition name in openmeteo provider which
lead to n/a icon (#3691)
- [core] Fix wrong port in log message when starting server only (#3696)
- [calendar] Fix NewYork event processed on system in Central timezone
shows wrong time #3701
- [weather/yr] The Yr weather provider is now able to recover from bad
API responses instead of freezing (#3296)
- [compliments] Fix evening events being shown during the day (#3727)
- [weather] Fixed minor spacing issues when using UV Index in Hourly
- [workflow] Fix command to run spellcheck

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael Teeuw <michael@xonaymedia.nl>
Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Karsten Hassel <hassel@gmx.de>
Co-authored-by: Ross Younger <crazyscot@gmail.com>
Co-authored-by: Bugsounet - Cédric <github@bugsounet.fr>
Co-authored-by: jkriegshauser <joshuakr@nvidia.com>
Co-authored-by: illimarkangur <116028111+illimarkangur@users.noreply.github.com>
Co-authored-by: sam detweiler <sdetweil@gmail.com>
Co-authored-by: vppencilsharpener <tim.pray@gmail.com>
Co-authored-by: Paranoid93 <6515818+Paranoid93@users.noreply.github.com>
Co-authored-by: Brian O'Connor <btoconnor@users.noreply.github.com>
Co-authored-by: WallysWellies <59727507+WallysWellies@users.noreply.github.com>
Co-authored-by: Jason Stieber <jrstieber@gmail.com>
Co-authored-by: jargordon <50050429+jargordon@users.noreply.github.com>
Co-authored-by: Daniel <32464403+dkallen78@users.noreply.github.com>
Co-authored-by: Ryan Williams <65094007+ryan-d-williams@users.noreply.github.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Marc Landis <dirk.rettschlag@gmail.com>
Co-authored-by: HeikoGr <20295490+HeikoGr@users.noreply.github.com>
Co-authored-by: Pedro Lamas <pedrolamas@gmail.com>
Co-authored-by: veeck <gitkraken@veeck.de>
Co-authored-by: Magnus <34011212+MagMar94@users.noreply.github.com>
Co-authored-by: Ikko Eltociear Ashimine <eltociear@gmail.com>
Co-authored-by: DevIncomin <56730075+Developer-Incoming@users.noreply.github.com>
Co-authored-by: Nathan <n8nyoung@gmail.com>
Co-authored-by: mixasgr <mixasgr@users.noreply.github.com>
Co-authored-by: Savvas Adamtziloglou <savvas-gr@greeklug.gr>
Co-authored-by: Konstantinos <geraki@gmail.com>
Co-authored-by: OWL4C <124401812+OWL4C@users.noreply.github.com>
@rejas rejas closed this as completed Apr 1, 2025
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@rejas rejas

Labels
bug ready (coming with next release)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@rejas @khassel