Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

chore: update newsfeed.js #3690

Closed
wants to merge 2 commits into from
Closed

Conversation

eltociear
Copy link

Therefor -> Therefore

sdetweil and others added 2 commits January 1, 2025 08:27
## [2.30.0] - 2025-01-01

Thanks to: @xsorifc28, @HeikoGr, @bugsounet, @khassel,
@KristjanESPERANTO, @rejas, @sdetweil.

> ⚠️ This release needs nodejs version `v20` or `v22 or higher`, minimum
version is `v20.18.1`

### Added

- [core] Add wayland and windows start options to `package.json` (MagicMirrorOrg#3594)
- [docs] Add step for npm publishing in release process (MagicMirrorOrg#3595)
- [core] Add GitHub workflow to run spellcheck a few days before each
release (MagicMirrorOrg#3623)
- [core] Add test flag to `index.html` to pass to module js for test
mode detection (needed by MagicMirrorOrg#3630)
- [core] Add export on animation names (MagicMirrorOrg#3644)
- [compliments] Add support for refreshing remote compliments file, and
test cases (MagicMirrorOrg#3630)
- [linter] Re-add `eslint-plugin-import`now that it supports ESLint v9
(MagicMirrorOrg#3586)
- [linter] Re-activate `eslint-plugin-package-json` to lint
`package.json` (MagicMirrorOrg#3643)
- [linter] Add linting for markdown files (MagicMirrorOrg#3646)
- [linter] Add some handy ESLint rules.
- [calendar] Add ability to display end date for full date events, where
end is not same day (showEnd=true) (MagicMirrorOrg#3650)
- [core] Add text to the config.js.sample file about the locale variable
(MagicMirrorOrg#3654, MagicMirrorOrg#3655)
- [core] Add fetch timeout for all node_helpers (thru undici, forces
node 20.18.1 minimum) to help on slower systems. (MagicMirrorOrg#3660) (3661)

### Changed

- [core] Run code style checks in workflow only once (MagicMirrorOrg#3648)
- [core] Fix animations export MagicMirrorOrg#3644 only on server side (MagicMirrorOrg#3649)
- [core] Use project URL in fallback config (MagicMirrorOrg#3656)
- [core] Fix Access Denied crash writing js/positions.js (on synology
nas) MagicMirrorOrg#3651. new message, MM starts, but no modules showing (MagicMirrorOrg#3652)
- [linter] Switch to 'npx' for lint-staged in pre-commit hook (MagicMirrorOrg#3658)

### Removed

- [tests] Remove `node-pty` and `drivelist` from rebuilded test (MagicMirrorOrg#3575)
- [deps] Remove `@eslint/js` dependency. Already installed with `eslint`
in deep (MagicMirrorOrg#3636)

### Updated

- [repo] Reactivate `stale.yaml` as GitHub action to mark issues as
stale after 60 days and close them 7 days later (if no activity) (MagicMirrorOrg#3577,
MagicMirrorOrg#3580, MagicMirrorOrg#3581)
- [core] Update electron dependency to v32 (test electron rebuild) and
all other dependencies too (MagicMirrorOrg#3657)
- [tests] All test configs have been updated to allow full external
access, allowing for easier debugging (especially when running as a
container)
- [core] Run and test with node 23 (MagicMirrorOrg#3588)
- [workflow] delete exception `allow-ghsas: GHSA-8hc4-vh64-cxmj` in
`dep-review.yaml` (MagicMirrorOrg#3659)

### Fixed

- [updatenotification] Fix pm2 using detection when pm2 script is inside
or outside MagicMirror root folder (MagicMirrorOrg#3576) (MagicMirrorOrg#3605) (MagicMirrorOrg#3626) (MagicMirrorOrg#3628)
- [core] Fix loading node_helper of modules: avoid black screen, display
errors and continue loading with next module (MagicMirrorOrg#3578)
- [weather] Change default value for weatherEndpoint of provider
openweathermap to "/onecall" (MagicMirrorOrg#3574)
- [tests] Fix electron tests with mock dates, the mock on server side
was missing (MagicMirrorOrg#3597)
- [tests] Fix testcases with hard coded Date.now (MagicMirrorOrg#3597)
- [core] Fix missing `basePath` where `location.host` is used (MagicMirrorOrg#3613)
- [compliments] croner library changed filenames used in latest version
(MagicMirrorOrg#3624)
- [linter] Fix ESLint ignore pattern which caused that default modules
not to be linted (MagicMirrorOrg#3632)
- [core] Fix module path in case of sub/sub folder is used and use
path.resolve for resolve `moduleFolder` and `defaultModuleFolder` in
app.js (MagicMirrorOrg#3653)
- [calendar] Update to resolve issues MagicMirrorOrg#3098 MagicMirrorOrg#3144 MagicMirrorOrg#3351 MagicMirrorOrg#3422 MagicMirrorOrg#3443
MagicMirrorOrg#3467 MagicMirrorOrg#3537 related to timezone changes
- [calendar] Fix MagicMirrorOrg#3267 (styles array), also fixes event with both exdate
AND recurrence(and testcase)
- [calendar] Fix showEndsOnlyWithDuration not working, MagicMirrorOrg#3598, applies
ONLY to full day events
- [calendar] Fix showEnd for Full Day events (MagicMirrorOrg#3602)
- [tests] Suppress "module is not defined" in e2e tests (MagicMirrorOrg#3647)
- [calendar] Fix MagicMirrorOrg#3267 (styles array, really this time!)
- [core] Fix MagicMirrorOrg#3662 js/positions.js created incorrectly

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: Michael Teeuw <michael@xonaymedia.nl>
Co-authored-by: Kristjan ESPERANTO <35647502+KristjanESPERANTO@users.noreply.github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Karsten Hassel <hassel@gmx.de>
Co-authored-by: Ross Younger <crazyscot@gmail.com>
Co-authored-by: Veeck <github@veeck.de>
Co-authored-by: Bugsounet - Cédric <github@bugsounet.fr>
Co-authored-by: jkriegshauser <joshuakr@nvidia.com>
Co-authored-by: illimarkangur <116028111+illimarkangur@users.noreply.github.com>
Co-authored-by: vppencilsharpener <tim.pray@gmail.com>
Co-authored-by: veeck <michael.veeck@nebenan.de>
Co-authored-by: Paranoid93 <6515818+Paranoid93@users.noreply.github.com>
Co-authored-by: Brian O'Connor <btoconnor@users.noreply.github.com>
Co-authored-by: WallysWellies <59727507+WallysWellies@users.noreply.github.com>
Co-authored-by: Jason Stieber <jrstieber@gmail.com>
Co-authored-by: jargordon <50050429+jargordon@users.noreply.github.com>
Co-authored-by: Daniel <32464403+dkallen78@users.noreply.github.com>
Co-authored-by: Ryan Williams <65094007+ryan-d-williams@users.noreply.github.com>
Co-authored-by: Panagiotis Skias <panagiotis.skias@gmail.com>
Co-authored-by: Marc Landis <dirk.rettschlag@gmail.com>
Co-authored-by: HeikoGr <20295490+HeikoGr@users.noreply.github.com>
Co-authored-by: Pedro Lamas <pedrolamas@gmail.com>
Co-authored-by: veeck <gitkraken@veeck.de>
Therefor -> Therefore
@rejas
Copy link
Collaborator

rejas commented Jan 13, 2025

Thanks but please base your PR against the develop branch

@eltociear eltociear changed the base branch from master to develop January 13, 2025 17:47
@eltociear eltociear closed this Jan 13, 2025
rejas pushed a commit that referenced this pull request Feb 1, 2025
Therefor -> Therefore

refs: #3690
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants