Refactor exception classes #1129
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Moved `PostgresMessageMeta` and `PostgresMessage` into their own file to make it easier to add typings later on * Re-exported `PostgresMessageMeta` and `PostgresMessage` from `asyncpg.exceptions._base` to maintain backwards compatibility * Removed `import asyncpg` statements and import within methods to prevent circular imports
eltoder
reviewed
Mar 5, 2024
| import sys | ||
| import textwrap | ||
| # PostgresMessageMeta imported for backward compatibility | ||
| from ._postgres_message import ( # noqa: F401 |
There was a problem hiding this comment.
You can add them to __all__. Then you won't need as and noqa.
There was a problem hiding this comment.
If I do that, then they will be imported with from ._base import * in asyncpg/exceptions/__init__.py, and then they will be accessible as asyncpg.PostgresMessage and asyncpg.PostgresMessageMeta
elprans
approved these changes
Oct 22, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PostgresMessageMetaandPostgresMessageinto their own file to make it easier to add typings later onPostgresMessageMetaandPostgresMessagefromasyncpg.exceptions._baseto maintain backwards compatibilityimport asyncpgstatements and import within methods to prevent circular imports