Skip to content

Fix "implicit optional", e.g. arg: int = None #1239

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Merged
merged 2 commits into from
Mar 16, 2025

Conversation

andrew222651
Copy link
Contributor

The latest version of Pyright makes calling a function with an "implicit optional" a type error. An "implicit optional" is like the following code, where a parameter is annotated with a type that doesn't include None but the default value is None:

def foo(arg: int = None):
    pass

More info here: https://docs.astral.sh/ruff/rules/implicit-optional/

This PR adds typing.Optional where necessary.

@elprans elprans merged commit 07e163f into MagicStack:master Mar 16, 2025
1 of 41 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants