Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

The Glow border does not follow the window is is used the UseNoneWindowStyle property! #2339

Closed
gigios opened this issue Feb 4, 2016 · 6 comments
Assignees
Milestone

Comments

@gigios
Copy link

gigios commented Feb 4, 2016

I'm playing to simulate the WindowStyle = None behavior, to do this I set some properties in the MetroWindow (UseNoneWindowStyle, IsWindowDraggable).
If my app start with the UseNoneWindowStyle set to false, I can see the TitleBar and I'm able to drag the window with the correct glow effect.
If I change in my ViewModel the UseNoneWindowStyle property (in binding with the Win property) the window hide the TitleBar and I'm not able to drag (because I have also IsWindowDraggable in binding), and this is correct!
If my app start immediately with the UseNoneWindowStyle set to true and IsWindowDraggable to false, the window is not draggable correctly but, when I change my properies in the ViewModel, I'm able to drag the window and to see (not perfectly, but this is another issue) the TitleBar.
The problem is that the glow border does not follow the dragging window!

@Camuvingian
Copy link

I also have this problem. The glow was working fine before I updated to the very latest version...

@punker76
Copy link
Member

@gigios @Camuvingian the glow is explicit ignored if the UseNoneWindowStyle is true or no GlowBrush is set

@punker76
Copy link
Member

don't know if this makes sense

@punker76
Copy link
Member

^ /cc @thoemmi what do you think? i think we can delete this check.

@punker76 punker76 added this to the 1.3.0 milestone Feb 15, 2016
@punker76 punker76 self-assigned this Feb 15, 2016
@thoemmi
Copy link
Collaborator

thoemmi commented Feb 15, 2016

As far as I can see the problem is that GlowWindowBehavior.IsGlowDisabled is checked only right after the window is loaded/source is initialized. It was never meant to be changed at runtime, so if you change UseNoneWindowStyle or GlowBrush afterwards it is too late.

I guess removing the check in GlowWindowBehavior.OnAttached would be ok.

punker76 added a commit that referenced this issue Apr 19, 2016
the Glow windows should be also available if UseNoneWindowStyle is true (this means we want a really WindowStyle=None)
@punker76
Copy link
Member

@gigios The glow is now also available if UseNoneWindowStyle is set to true. 7ca4666

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Development

No branches or pull requests

4 participants