Tab Control Underline Position #3524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t regardless of the tabstripplacement property on the tab controls, works with animated, regular and animated single row tab controls
…to tcunderline_position Merging for pull request for feature -> tab control underline position is now a dependency property
Adds a new boolean property to configure the initial checked state of the remember checkbox
|
FYI the 2 problems found by Codacy are FPs (the methods can't be made static as they are interface implementations). |
Fix all TabControl styles to use the Underlined TabPanel again. Remove the PlacementToOppositePlacementConverter and change the UnderlinePlacement type to allow nullable Dock value. With these changes we don't need the PlacementToOppositePlacementConverter and get the old default behavior back.
Add a ComboBox to set the new UnderlinePlacement property.
|
@jammerxd @Evangelink your changes have been merged, thanks for your contribution 👍 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the changes you have made to improve this project
A dependency property
UnderlinePlacementwas added to theTabControlHelperclass that allows a person to set the underline position in the various tab controls. The property is aDocktype and can be set toNull(default),Left,Right,ToporBottomrespectively.Additional context
See #3048
I have tried to follow this tutorial to get my change onto @jammerxd PR but couldn't manage to do so. Feel free to just cherry-pick the commit(s) and push them back to the original PR.
Closes #3048