Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Adminhtml: Fixed active menu highlighting #12

Merged

Conversation

tmewes
Copy link
Contributor

@tmewes tmewes commented Aug 31, 2024

Description

When selecting some menu items in the adminhtml, the entry is not highlighted/underlined (e.g. System > Notifications) when the page is loaded because of wrong menu paths in _setActiveMenu or the call of this method is completely missing.

This PR fixes the menu highlighting.

Type of change

Fix

How can this feature be tested

  1. Visit Maho's adminhtml.
  2. Click through the different menu entries.
  3. The active menu entry should always be highlighted correctly.

@fballiano fballiano changed the title Adminhtml: Fix Active Menu Highlighting Adminhtml: Fixed active menu highlighting Sep 1, 2024
@fballiano
Copy link
Contributor

Beautiful, thank you!

@fballiano fballiano merged commit 37dee77 into MahoCommerce:main Sep 1, 2024
9 of 11 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants