Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Rename LineModel.connections to LineModel.edges #108

Open
Makman2 opened this issue Aug 19, 2016 · 4 comments
Open

Rename LineModel.connections to LineModel.edges #108

Makman2 opened this issue Aug 19, 2016 · 4 comments
Assignees
@AsnelChristian
Milestone
3.0

Comments

@Makman2
Copy link
Owner

Makman2 commented Aug 19, 2016

This name is more compliant with other software and also more descriptive.
@Makman2 Makman2 added this to the 2.1 milestone Aug 19, 2016
@Makman2 Makman2 modified the milestones: 3.0, 2.1 Sep 24, 2016
@AsnelChristian
Copy link
Collaborator

can i work on this

@Makman2
Copy link
Owner Author

Makman2 commented Jun 9, 2017

Because this is an API break, we have to release 3.0 as next release then 👍

AsnelChristian added a commit to AsnelChristian/CE3D2 that referenced this issue Jun 9, 2017
@AsnelChristian
LineModel: Rename connections() to edges()
626cc2a 
Closes Makman2#108
AsnelChristian added a commit to AsnelChristian/CE3D2 that referenced this issue Jun 9, 2017
@AsnelChristian
LineModel: Rename connections() to edges()
0d60e99 
Closes Makman2#108
AsnelChristian added a commit to AsnelChristian/CE3D2 that referenced this issue Jun 9, 2017
@AsnelChristian
LineModel: Rename connections() to edges()
e4d1643 
Closes Makman2#108
AsnelChristian added a commit to AsnelChristian/CE3D2 that referenced this issue Jun 9, 2017
@AsnelChristian
LineModel: Rename connections() to edges()
c959c83 
Closes Makman2#108
@Ananthavijay
Copy link

can i work on this @Makman2

@Makman2
Copy link
Owner Author

Makman2 commented Feb 15, 2018

We should really do this later as this breaks API (that's why it's scheduled for https://github.com/Makman2/CE3D2/milestone/4), I want to do as many issues as possible that keep the API as is.

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@AsnelChristian AsnelChristian

Labels
None yet
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
3 participants
@Makman2 @AsnelChristian @Ananthavijay