Fix side effects in RequestHeadersConstraint #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The constructor in RequestHeadersConstraint takes in a array of header
parameters from the Swagger definition and modifies them by calling
`unset($headerParameter->name);` and `unset($headerParameter->required);`.
This changes the definition and can cause subsequent assertions to fail.
The RequestQueryConstraint constructor calls
`$queryParameter = clone $queryParameter;` to prevent this, so I just did
the same here.
?>
|
Thanks. Could you apply the same fix to |
|
Looks like it already handles that properly: https://github.com/Maks3w/SwaggerAssertions/blob/master/src/PhpUnit/RequestQueryConstraint.php#L21 |
|
released |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The constructor in RequestHeadersConstraint takes in a array of header parameters from the Swagger definition and modifies them by calling
unset($headerParameter->name);andunset($headerParameter->required);. This changes the definition and can cause subsequent assertions to fail.The RequestQueryConstraint constructor calls
$queryParameter = clone $queryParameter;to prevent this, so I just did the same here.