♻️ Refactor QuestionStatisticsForQuestion component to simplify props…

… and improve layout
Malte2036 · Oct 30, 2024 · 29cf08f · 29cf08f
1 parent 5655527
commit 29cf08f
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 17 deletions.
diff --git a/src/lib/quiz/question/QuestionStatisticsForQuestion.svelte b/src/lib/quiz/question/QuestionStatisticsForQuestion.svelte
@@ -1,11 +1,8 @@
 <script lang="ts">
-	import type { AnsweredCountData } from '../../../routes/(main)/quiz/[type]/[questionId]/+page.server';
-	import QuestionsStatistics from './QuestionsStatistics.svelte';
 	import type { QuestionType } from '$lib/model/question';
+	import type { AnsweredCountData } from '../../../routes/(main)/quiz/[type]/[questionId]/+page.server';
 
-	export let answeredCountData: AnsweredCountData | undefined;
 	export let currentQuestionAnsweredCountData: AnsweredCountData | undefined;
-	export let questionType: QuestionType;
 
 	function getQuizTypeName(type: QuestionType) {
 		switch (type) {
@@ -42,7 +39,7 @@
 				/>
 			</div>
 			<span class="text-sm text-gray-600 whitespace-nowrap font-medium">
-				<span class="inline-block w-[4ch] text-right">{currentCorrectPercentage ?? ''}</span>%
+				<span class="inline-block min-w-[4ch] text-right">{currentCorrectPercentage ?? ''}</span>%
 				richtig
 			</span>
 		</div>
@@ -52,11 +49,4 @@
 			Mal richtig
 		</p>
 	</div>
-
-	<div>
-		<h3 class="text-lg font-medium text-gray-700 mb-2">
-			Globale Statistik {getQuizTypeName(questionType)}
-		</h3>
-		<QuestionsStatistics {answeredCountData} {questionType} />
-	</div>
 </div>
diff --git a/src/routes/(main)/quiz/[type]/[questionId]/+page.svelte b/src/routes/(main)/quiz/[type]/[questionId]/+page.svelte
@@ -143,10 +143,6 @@
 				/>
 			</div>
 		</div>
-		<QuestionStatisticsForQuestion
-			{answeredCountData}
-			{currentQuestionAnsweredCountData}
-			{questionType}
-		/>
+		<QuestionStatisticsForQuestion {currentQuestionAnsweredCountData} />
 	</div>
 </div>