Make websockets work again #255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit changes the proxy directives added in ManageIQ#208 to rewrite rules which seem to play better with the existing rules put in place for auth. Before this, notifications did not work properly and httpd processes were starting constantly and not exiting. https://bugzilla.redhat.com/show_bug.cgi?id=1526601 Note: This seems to have been working before 7e86fe9, but somehow the RewriteRule added there messes with the ws proxy.
|
Checked commit carbonin@1d680df with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0 **
|
|
Hi @carbonin, changes are good here 👍 Just tested IPA, IPA SSO (kerberos), SAML and OpenIDC, all good. |
bdunne
approved these changes
Dec 18, 2017
simaishi
pushed a commit
that referenced
this pull request
Dec 18, 2017
Make websockets work again (cherry picked from commit c54aa15) https://bugzilla.redhat.com/show_bug.cgi?id=1527115
|
Gaprindashvili backport details: |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes the proxy directives added in #208 to rewrite rules which seem to play better with the existing rules put in place for auth.
Before this, notifications did not work properly and httpd processes were starting constantly and not exiting.
https://bugzilla.redhat.com/show_bug.cgi?id=1526601
Note:
This seems to have been working before 7e86fe9, but somehow the RewriteRule added there messes with the ws proxy.
@abellotti can you test auth out with this change?
@skateman does this make sense to you?