Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

drop use of unsupported_reason_add #244

Merged
merged 1 commit into from
Feb 26, 2024

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Feb 23, 2024

part of:

Deprecating unsupported_reason_add. Returning the string instead

Note, these are all the same:

unsupported_reason_add(:feature, unsupported_reason(:feature2)) unless supports_feature2?
unsupported_reason_add(:feature, unsupported_reason(:feature2)) unless supports?(:feature2)
unsupported_reason(:feature2) unless supports?(:feature2)
unsupported_reason(:feature2)

@miq-bot
Copy link
Member

miq-bot commented Feb 23, 2024

Checked commit kbrock@e4b9931 with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
4 files checked, 0 offenses detected
Everything looks fine. 🏆

@agrare agrare merged commit 888c891 into ManageIQ:master Feb 26, 2024
4 checks passed
@kbrock kbrock deleted the unsupports_supports branch February 27, 2024 18:01
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants