-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
drop use of unuspported_reason_add #260
Conversation
22f8c6e
to
2df56f7
Compare
update:
|
supports :terminate do | ||
unsupported_reason_add(:terminate, unsupported_reason(:control)) unless supports?(:control) | ||
end | ||
supports(:terminate) { unsupported_reason(:control) unless supports?(:control) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this can simply be
supports(:terminate) { unsupported_reason(:control) unless supports?(:control) } | |
supports(:terminate) { unsupported_reason(:control) } |
right?
_("The VM is not powered on") | ||
end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_("The VM is not powered on") | |
end | |
_("The VM is not powered on") | |
end | |
end |
2df56f7
to
65a2d7a
Compare
Checked commit kbrock@65a2d7a with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint |
part of:
Deprecating
unsupported_reason_add
. Returning the string insteadNote, these are all the same: