drop use of unsupported_reason_add

[kbrock]

@agrare I see that we added instantiate_supported? in c7213d3

Do we still need that?
I don't see it defined or extended anywhere.

Alternatively, can we just use instantiate_unsupported_reason and drop the instantiate_supported? ?

ANSWER: punting for now

---

part of:

• Drop supports_feature? methods manageiq#22883

Deprecating unsupported_reason_add. Returning the string instead

Note, these are all the same:

unsupported_reason_add(:feature, unsupported_reason(:feature2)) unless supports_feature2?
unsupported_reason_add(:feature, unsupported_reason(:feature2)) unless supports?(:feature2)
unsupported_reason(:feature2) unless supports?(:feature2)
unsupported_reason(:feature2)

[agrare]

The instantiate_supported code was there to allow us to optionally disable this support, I'm not sure if we still need that @Fryguy ?

[agrare]

@kbrock I think we should keep this method for now since we override it in some scenarios but we could drop it in the future
Can you drop the TODO comments?

[kbrock]

update:

• dropped TODO comments

[miq-bot]

Checked commit kbrock@0e97a0e with ruby 2.7.8, rubocop 1.56.3, haml-lint 0.51.0, and yamllint
1 file checked, 0 offenses detected
Everything looks fine. ⭐