Bower to npm - move angular 1 to npm

[himdel]

Continuing the effort from #3343, overall description there.

This moves angular 1 from bower to npm, no other changes.

[ohadlevy]

maybe I'm missing something obvious - but why not move it to webpack as well? I think long term it makes more sense to have npm packages + webpack vs npm + asset pipeline?

[miq-bot]

This pull request is not mergeable. Please rebase and repush.

[himdel]

Step by step :) You're right, it does .. but I want us to get off bower first, without dealing with moving stuff to webpack at the same time.

(See "Next steps" in #3343)

EDIT: updated the description accordingly

[himdel]

This line is autogenerated when running bower install -F, keeping for now, otherwise everybody will see a local change after bin/update.

[himdel]

Test failure caused by Rails.application.config.assets.paths still containing bower_components, because railties thinks it's a good idea :).

Looking into whether we can remove it from the paths, or if we need to move bower elsewhere.

---

Looks like we can't, not in a rails engine. Moving bower to a different dir.

=> #3388

[himdel]

Pending #3388
@miq-bot add_label wip
@miq-bot remove_label wip

EDIT: merged

[miq-bot]

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/eeb27b0ed60088cd0dd81776af30bb9ca0ec8d8c~...1dc0bbd3427fb891cd361ee549aba34144b249ed with ruby 2.3.3, rubocop 0.52.0, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. ⭐

[himdel]

Cc @mzazrivec ;)

[himdel]

issue: #3734