lodash - move to npm, upgrade to lodash 4 #4578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miq-bot
changed the title
himdel
changed the title
this moves all lodash to npm that means we no longer have lodash 3 available anywhere
we already had a bunch of comments re lodash4 compatibility, fixing those
instead of +-Infinity as in lodash3
and given the one used is _.isEqual, we don't really need `differenceBy`
except we have all the shims, so using JS-native includes
|
Checked commits https://github.com/himdel/manageiq-ui-classic/compare/7ac0a2a42f4d2376954370ce307ad6760729af0f~...30383e3da9b487cdebc57e1cd531c4b3bac87d47 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0 |
|
Also verified ui-components should no longer depend on lodash3 at all. |
|
@miq-bot remove_label wip |
miq-bot
changed the title
skateman
reviewed
Sep 3, 2018
| var seriesIndex = _.contains(['Pie', 'Donut'], generate_args.miqChart) ? index : index - 1; | ||
| var pointIndex = _.contains(['Pie', 'Donut'], generate_args.miqChart) ? index : data.index; | ||
| var seriesIndex = ['Pie', 'Donut'].includes(generate_args.miqChart) ? index : index - 1; | ||
| var pointIndex = ['Pie', 'Donut'].includes(generate_args.miqChart) ? index : data.index; |
There was a problem hiding this comment.
I hope we got a shim for this...
There was a problem hiding this comment.
es6-shim :) EDIT: or array-includes maybe :)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves all lodash to npm - that means we no longer have lodash 3 available anywhere, and are always using lodash 4.
Following https://github.com/lodash/lodash/wiki/Changelog#compatibility-warnings to fix any incompatibilities.
Issue #3734