Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

bower to npm: angular-dragdrop & angular-ui-sortable #4640

Merged
merged 2 commits into from
Sep 12, 2018
Merged

bower to npm: angular-dragdrop & angular-ui-sortable #4640

merged 2 commits into from
Sep 12, 2018

Conversation

himdel
Copy link
Contributor

@himdel himdel commented Sep 11, 2018

2 angular libraries not directly used by ui-classic but depended on by ui-components.
Both in same version.

testing

angular.element('.ng-scope').injector().get('ngDragDropService')
angular.element('.ng-scope').injector().get('uiSortableConfig')

Issue #3734

not directly used by ui-classic
but depended on by ui-components

same version

```
angular.element('.ng-scope').injector().get('ngDragDropService')
```
same version

```
angular.element('.ng-scope').injector().get('uiSortableConfig')
```
@himdel himdel changed the title bower to npm: angular-dragdrop bower to npm: angular-dragdrop & angular-ui-sortable Sep 11, 2018
@miq-bot
Copy link
Member

miq-bot commented Sep 11, 2018

Checked commits https://github.com/himdel/manageiq-ui-classic/compare/78ecc50f6465f5377121705335f1e6e483143b40~...7cdeba0f11653c81c758bdc3236590c37397d109 with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0
0 files checked, 0 offenses detected
Everything looks fine. 🍪

@mzazrivec mzazrivec self-assigned this Sep 12, 2018
@mzazrivec mzazrivec added this to the Sprint 95 Ending Sep 24, 2018 milestone Sep 12, 2018
@mzazrivec mzazrivec merged commit b53aa07 into ManageIQ:master Sep 12, 2018
@himdel himdel deleted the bower-dragdrop branch September 13, 2018 08:35
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants