Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove unused routes from the miq_policy_controller #7087

Merged
merged 1 commit into from
May 29, 2020

Conversation

skateman
Copy link
Member

The _get_all routes are no longer used as the action_url local variable is not being used in the layouts/gtl anymore. There's a callsite to each method though, from tree_select methods, so I kept the method definitions. The action_tag_pressed method has been probably deleted when we started using the new tagging screen.

@miq-bot
Copy link
Member

miq-bot commented May 28, 2020

Checked commit skateman@fb02291 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint
5 files checked, 4 offenses detected

app/views/miq_policy/_action_list.html.haml

  • ⚠️ - Line 2 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 2 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.

app/views/miq_policy/_alert_list.html.haml

  • ⚠️ - Line 2 - Layout/ExtraSpacing: Unnecessary spacing detected.
  • ⚠️ - Line 2 - Layout/SpaceAroundOperators: Operator => should be surrounded by a single space.

@mzazrivec mzazrivec merged commit 590486b into ManageIQ:master May 29, 2020
@mzazrivec mzazrivec self-assigned this May 29, 2020
@skateman skateman deleted the policy-unused-routes branch May 29, 2020 11:13
simaishi pushed a commit that referenced this pull request Jun 11, 2020
Remove unused routes from the miq_policy_controller

(cherry picked from commit 590486b)
@simaishi
Copy link
Contributor

Jansa backport details:

$ git log -1
commit 74ed7e5790830a8954e4e3537537aac6e2320f62
Author: Milan Zázrivec <mzazrivec@redhat.com>
Date:   Fri May 29 13:00:57 2020 +0200

    Merge pull request #7087 from skateman/policy-unused-routes

    Remove unused routes from the miq_policy_controller

    (cherry picked from commit 590486b43cdc573f32b343124ea378f23635ec71)

# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants