[Gemfile] Remove "second" source #7152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we inherit the `Gemfile` from `ManageIQ/manageiq` in this repo,
there is now a deprecation warning when running `bundler` v2.1.4:
[DEPRECATED] Your Gemfile contains multiple primary sources. Using
`source` more than once without a block is a security risk...
This is because there is a duplicate source when evaling the `Gemfile`
from `ManageIQ/manageiq`. Since that one needs to stay, removing this
one allows `bundle update` and friends to continue to work without the
deprecation warning.
|
Checked commit NickLaMuro@5933af7 with ruby 2.5.7, rubocop 0.69.0, haml-lint 0.28.0, and yamllint |
mzazrivec
approved these changes
Jun 29, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we inherit the
GemfilefromManageIQ/manageiqin this repo, there is now a deprecation warning when runningbundlerv2.1.4:This is because there is a duplicate source when evaling the
GemfilefromManageIQ/manageiq. Since that one needs to stay, removing this one allowsbundle updateand friends to continue to work without the deprecation warning.Links
travisprior to this fixtravisrun for this PR (no deprecation warning inbin/setup)