More s390x lockdowns #1861
Merged
More s390x lockdowns #1861
+41
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit builds on top of ManageIQ#1860 to add more package lockdowns in order to prevent es-abstract 1.22 from being installed in the s390x environment since that env has problems with it when run under yarn 1 (Reminder that we need yarn 1 for the time-being because builds on yarn 3 hang on s390x, however yarn 1 ignores the lockfile and installs the latest version regardless, which sometimes brings in packages that are problematic; in this case es-abstract 1.22)
|
Wow, 🤯 |
jrafanie
approved these changes
Sep 8, 2023
|
Checked commit Fryguy@d72356f with ruby 2.6.10, rubocop 1.28.2, haml-lint 0.35.0, and yamllint |
|
@jrafanie That's correct but in the other direciton. We are locking down to the previous patch release, otherwise the newer patch release brings in es-abstract 1.22 which breaks on s390x. Strangely, I can't just straight for es-abstract 1.21, which is why we have to change everything that could end up bringing in 1.22 😞 See the diff in the OP, but specifically look at es-abstract in each section. |
|
Backported to |
Fryguy
pushed a commit
that referenced
this pull request
Sep 8, 2023
More s390x lockdowns (cherry picked from commit f0a0710)
Fryguy
added a commit
to Fryguy/manageiq-ui-service
that referenced
this pull request
Dec 7, 2023
Now that we are on yarn 4.0.2, which can support newer versions of es-abstract on s390x, this commit reverts all of the lockdowns to packages for that reason. This commit reverts cf484a2 (ManageIQ#1857), 95f6c55/68335b56 (ManageIQ#1860), and d72356f (ManageIQ#1861)
Merged
Fryguy
added a commit
to Fryguy/manageiq-ui-service
that referenced
this pull request
Dec 7, 2023
Now that we are on yarn 4.0.2, which can support newer versions of es-abstract on s390x, this commit reverts all of the lockdowns to packages for that reason. This commit reverts cf484a2 (ManageIQ#1857), 95f6c55 / 68335b5 (ManageIQ#1860), and d72356f (ManageIQ#1861)
Fryguy
added a commit
to Fryguy/manageiq-ui-service
that referenced
this pull request
Dec 7, 2023
Now that we are on yarn 4.0.2, which can support newer versions of es-abstract on s390x, this commit reverts all of the lockdowns to packages for that reason. This commit reverts cf484a2 (ManageIQ#1857), 95f6c55 / 68335b5 (ManageIQ#1860), and d72356f (ManageIQ#1861)
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit builds on top of #1860 to add more package lockdowns in order to prevent es-abstract 1.22 from being installed in the s390x environment since that env has problems with it when run under yarn 1
(Reminder that we need yarn 1 for the time-being because builds on yarn 3 hang on s390x, however yarn 1 ignores the lockfile and installs the latest version regardless, which sometimes brings in packages that are problematic; in this case es-abstract 1.22)
@jrafanie @bdunne Please review. This is the yarn1 diff with these changes which shows es-abtract 1.22 no longer in the lockfile