[WIP] Rails 5 fix - depend on an express-http-proxy version that can handle Transfer-Encoding: chunked & IPv6 #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
himdel
changed the title
himdel
changed the title
|
@miq-bot add_label wip |
|
WIP because the IPv6 change is not quite finished.. |
Puma listens on ::1 by default, not 127.0.0.1. Also prepending http to be explicit about the protocol.
|
Checked commits https://github.com/himdel/manageiq-ui-self_service/compare/0aee3bf3cba42dded6c586d9c5a04aca5546a8fd~...39fd31c011122761dcba3a546b93192eca39f399 with ruby 2.2.3, rubocop 0.34.2, and haml-lint 0.13.0 |
|
Closing in favour of #11 - |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the
Parse errormessages (in node console) and the correspondingnet::ERR_EMPTY_RESPONSE(in browser).Also change the proxy from
127.0.0.1:3000tohttp://[::1]:3000, and updateexpress-http-proxyto parse that correctly.Not sure if we want to merge like this, or wait for villadora/express-http-proxy#47 and villadora/express-http-proxy#48.
Also relevant: nodejs/node#5308 - PR nodejs/node#5314