Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Bump config to ~>1.6.0 #16771

Merged
merged 1 commit into from
Jan 12, 2018
Merged

Conversation

carbonin
Copy link
Member

@carbonin carbonin commented Jan 8, 2018

This pulls in rubyconfig/config#167 which allows us to reference keys called "count" properly

This pulls in rubyconfig/config#167
which allows us to reference keys called "count" properly
@carbonin
Copy link
Member Author

carbonin commented Jan 8, 2018

Before:

irb(main):005:0> Settings.workers.worker_base.defaults.count
=> 13

After:

irb(main):001:0> Settings.workers.worker_base.defaults.count
=> 1

@miq-bot
Copy link
Member

miq-bot commented Jan 8, 2018

Checked commit carbonin@471a887 with ruby 2.3.3, rubocop 0.47.1, haml-lint 0.20.0, and yamllint 1.10.0
1 file checked, 0 offenses detected
Everything looks fine. 👍

Copy link
Member

@bdunne bdunne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@bdunne bdunne merged commit c409575 into ManageIQ:master Jan 12, 2018
@bdunne bdunne added this to the Sprint 77 Ending Jan 15, 2018 milestone Jan 12, 2018
@bdunne bdunne assigned bdunne and unassigned Fryguy Jan 12, 2018
simaishi pushed a commit that referenced this pull request Jan 12, 2018
Bump config to ~>1.6.0
(cherry picked from commit c409575)
@simaishi
Copy link
Contributor

Gaprindashvili backport details:

$ git log -1
commit 0da70a94bd8db298dc80bae37b4a48a45b9213ba
Author: Brandon Dunne <brandondunne@hotmail.com>
Date:   Fri Jan 12 16:56:43 2018 -0500

    Merge pull request #16771 from carbonin/bump_config_gem_version
    
    Bump config to ~>1.6.0
    (cherry picked from commit c4095756b18517c211cbeb7fba66f8efcfffb1e6)

@carbonin carbonin deleted the bump_config_gem_version branch August 16, 2019 17:28
# for free to join this conversation on GitHub. Already have an account? # to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants